mshillam
/
nvm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add test for NVM_DIR outside nvm.sh 

Fix symlink traversal
This commit is contained in:
Matt Saladna 2018-06-21 16:38:15 -04:00
parent 7d8b67ba6c
commit ca358b105e
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
nvm-exec
View File

@ -1,7 +1,8 @@
#!/usr/bin/env bash
SOURCE=${BASH_SOURCE[0]}
test -L "$SOURCE" && SOURCE=$(readlink "$SOURCE")
test -L "$SOURCE" && command cd "$( dirname "$SOURCE" )" && \
SOURCE=$(readlink "$SOURCE")
DIR="$(command cd "$( dirname "$SOURCE" )" && pwd )"
# shellcheck disable=SC1090

18
test/slow/nvm exec/Running "nvm exec --lts" when NVM_DIR differs from nvm Normal file
View File

@ -0,0 +1,18 @@
#!/bin/sh
set -ex
die () { echo "$@" ; exit 1; }
INSTPATH="$(mktemp -p "$(pwd)" -d)"
trap 'test ! -z "${INSTPATH-}" && test -d "$INSTPATH" && rm -rf "$INSTPATH"' EXIT
declare -x NVM_DIR=$INSTPATH
\. ../../../nvm.sh
nvm install --lts || die 'nvm install --lts failed'
nvm exec --lts npm --version || die "`nvm exec` failed to run"
declare -x NODE_VERSION="$(nvm exec --lts --silent node --version)"
ln -s ../../../../nvm-exec "$INSTPATH/nvm-exec" || die "failed to create a symlink to $INSTPATH/"
"$INSTPATH/nvm-exec" npm ls > /dev/null || die "`nvm exec` failed to run using nvm-exec helper"