Commit Graph

1800 Commits

Author SHA1 Message Date
Jordan Harband 2a259435c8
Merge pull request #1684 from PeterDaveHello/ShellCheck-v0.4.7-fixes
ShellCheck v0.4.7 fixes
2017-12-13 14:49:34 -08:00
Peter Dave Hello 2a8a81da94 [Fix] ShellCheck SC1117 in nvm.sh & install.sh 2017-12-14 03:26:17 +08:00
Peter Dave Hello fce7f4ed13 [Fix] Disable ShellCheck SC2207 in bash_completion line 14 2017-12-14 02:11:50 +08:00
Jordan Harband 7ad6d98ced
v0.33.8 2017-12-12 10:43:17 -08:00
Jordan Harband fa9c50520d [Fix] `nvm install-latest-npm`: fix for node 4.5/4.6. 2017-12-12 00:13:00 -08:00
Jordan Harband 4846d57c69
`nvm use`: perfect pre-npm-config env var checking 2017-12-05 00:00:18 -08:00
Jordan Harband 65f0572bdc
v0.33.7
Fixes
 - fix unassigned variable (#1665, #1664)
 - Fix for $path used by zsh (#1669)
 - `set -u`: ensure `NVM_USE_OUTPUT` is always set (#1671)
 - `install.sh`: Fix a bug that block that installation of node in install.sh (#1676)
 - `nvm install-latest-npm`: fix node 4-4.6

Documentation
 - Make `nvm cache clear` message less ambiguous (#1644)
 - Added missing piece (#1658)
2017-12-08 21:21:42 -08:00
Jordan Harband b6a7a54d04
[Fix] `nvm install-latest-npm`: fix node 4-4.6 2017-12-08 21:20:59 -08:00
Jordan Harband 8a8dcbb393
Merge pull request #1676 from Quadric/fix-node-version-in-install-script
`install.sh`: Fix a bug that block that installation of node in install.sh
2017-12-03 11:47:39 -08:00
Ahmad Magdy bacdd95591 Update test/install_script/nvm_install_with_node_version to use nvm ls 8 instead of grep! 2017-11-30 15:33:01 +01:00
Ahmad Magdy 4b0563093c Add test nvm_install_with_node_version under test/install_script 2017-11-30 15:23:37 +01:00
Ahmad Magdy c7ac69bfbb Fix nvm_install_node function in install.sh script to not override the actual NODE_VERSION value 2017-11-30 14:47:42 +01:00
Jordan Harband a57fe846e8
[Fix] `set -u`: ensure `NVM_USE_OUTPUT` is always set.
Fixes #1671.
2017-11-23 10:02:37 -06:00
Jordan Harband 7bfd1e0644
Merge pull request #1669 from mail6543210/master
Fix for $path used by zsh
2017-11-22 08:52:13 -08:00
mail6543210 9352f6913a Add symbolic link for printf in case of command-not-found 2017-11-22 02:01:38 +08:00
mail6543210 16d3e6d2dc Remove unnecessary, incorrect workaround.
The "\printf" calls zsh shell builtin instead of `command printf` in scripting.

The workaround is no longer needed given 91a29c0.
2017-11-22 00:57:27 +08:00
mail6543210 91a29c0da2 Fix for $path used by zsh
"The lower-case version of PATH is an array parameter
bound to the scalar upper-case parameter."
-- http://www.zsh.org/mla/users/2015/msg00178.html
2017-11-20 22:32:13 +08:00
Jordan Harband 4b48556e92
Merge pull request #1665 from norpol/fix_issue_1664_unassigned_variable_20171115
Fix #1664: unassigned variable
2017-11-17 23:31:26 -06:00
Phileas Lebada be171bba33 Add unset-variable as exit error 2017-11-15 17:19:05 +01:00
Phileas Lebada 049a86022f Add empty value to local variable 2017-11-15 17:17:57 +01:00
David Gatti a7b7eec0c5
[Docs] Added missing piece
This sentence broke my brain when I read it the first time :) I hope this helps.
2017-11-08 01:02:15 +01:00
Jordan Harband 9953a52afb
Merge pull request #1644 from citrusui/patch-1
[Docs] Make `nvm cache clear` message less ambiguous
2017-10-28 22:42:14 -07:00
Avery Magnotti fc30e0ade4
Make `nvm cache clear` message less ambiguous 2017-10-28 20:30:28 -04:00
Jordan Harband b546436113
v0.33.6 2017-10-23 23:53:26 -07:00
Darío Hereñú 016bc134d5 Typo 2017-10-23 02:23:04 -03:00
Peter Dave Hello 9c25a8f316 [Cleanup] Remove ghc related things in .travis.yml, cc #1619 2017-10-22 00:42:07 +08:00
Christopher Beland a954458829
[Docs] Improve git installation instructions 2017-10-18 10:39:11 -04:00
Jordan Harband 09951b49c5 Only apps should have lockfiles 2017-10-05 13:34:54 -07:00
Jordan Harband 3b133fac2f
[Fix] `install-latest-npm`: `npm` `v5.4`+ breaks on `node` `v4.5` and `v4.6`. 2017-10-04 11:04:27 -07:00
Michał Gołębiowski-Owczarek 6ac8ebafba Add a Git .mailmap with my new name
In this way my past contributions are mapped correctly.
2017-10-04 12:55:41 +02:00
Jordan Harband 62fb0d0ad6 Merge pull request #1605 from PeterDaveHello/fix-install.sh
[Fix] install.sh shouldn't use not existed variable
2017-10-03 22:23:48 -07:00
Peter Dave Hello a461a0fffc [Fix] install.sh shouldn't use not existed $NVM_PROFILE 2017-10-04 10:10:47 +08:00
Jordan Harband 6597e11971
v0.33.5 2017-09-29 12:50:27 -04:00
Jordan Harband 707d268a76 Merge pull request #1619 from PeterDaveHello/refactor-travis-config
Remove the manual ShellCheck install proecss on Travis CI
2017-09-28 10:45:49 -07:00
Peter Dave Hello 73ad812215 Remove the manual ShellCheck install proecss on Travis CI 2017-09-29 00:22:43 +08:00
Jordan Harband 8c578b864d [Fix] ensure all `grep` calls go through `nvm_grep`.
Fixes #1615.
2017-09-22 19:11:43 -07:00
Peter Dave Hello d535c97d0f Enhance nvm debug with more tools info 2017-09-21 22:09:15 +08:00
Peter Dave Hello e367533eb8
[Refactor] Reduce one more `sed` & pipe to speedup 2017-03-28 23:15:35 +08:00
Peter Dave Hello 6534568745 [Fix] Enhance nvm debug for different environments 2019-01-12 14:17:01 +08:00
Waldir Pimenta 13f3cdcdf7
README: clarify how to specify default packages 2019-01-11 10:42:33 +00:00
Jordan Harband 3d9c31d944
v0.34.0 2019-01-07 23:01:16 -08:00
Jordan Harband 0acccb8a77
Merge pull request #1974 from valeriemettler/valeriemettler-patch-1
[Docs] Improve phrasing of 'nvm current'
2019-01-05 14:10:31 -08:00
Valerie Mettler 6354b170d7
Improve phrasing of 'nvm current'
To help beginners know that 'nvm current' is talking about node and not nvm.
2019-01-05 12:20:56 -08:00
Javier Infante 5e065ec026 [Docs] fixing cdnvm on .bashrc 2018-12-31 08:42:58 +01:00
Peter Dave Hello 206d503a21
[Docs] Improve indent of output block in GitHub Issue template 2018-12-26 03:46:13 +08:00
Jordan Harband deb2a9b821
[Docs] fix eclint 2018-12-19 15:36:24 -08:00
Joel Parker Henderson fb83eeb140
[Docs] Add Ansible task example
Add Ansible task example to show how to install nvm and update it.

Ansible is a systems administration tool.
See https://github.com/ansible/ansible

My personal experience of `nvm` is that installing via Ansible is good, and that a good example can help. This example took me about an hour to learn, so I'm hoping to save other people some time. This example is somewhat different than any others that I found on the web. There may be a better way to write it, and if so, please improve it.
2018-12-19 12:45:59 -08:00
Peter Dave Hello 14179bc8ce
[shellcheck] Use `-n/-z` instead of `! -z/! -n` condition
https://github.com/koalaman/shellcheck/wiki/SC2236
2018-12-03 13:59:19 +08:00
Jordan Harband 153506c8da
[shellcheck] ignore SC2230 errors 2018-11-25 16:22:25 -08:00
Jordan Harband c1150c41ab
[Tests] avoid using shopt in zsh 2018-11-26 11:18:11 -08:00