Commit Graph

2074 Commits

Author SHA1 Message Date
Yash Singh 164ce09345
Merge c06050d079 into 39d9a42c35 2022-02-08 21:51:09 +01:00
Jordan Harband 39d9a42c35
[Fix] `install.sh`: error out if the install instructions are not followed 2022-02-08 10:40:11 -08:00
Yash Singh c06050d079
Merge branch 'master' into master 2022-01-28 11:01:55 -08:00
Kai 2c0c34f10e
[Docs] HTTP => HTTPS 2022-01-16 14:25:11 +01:00
Jordan Harband c2f740ab38
[patch] HTTP -> HTTPS 2022-01-18 12:49:57 -08:00
Jordan Harband 6cfaede5a0
[Fix] `install`: better error message when xcode command line tools are needed
Fixes #2697. Fixes #2663.
2021-11-27 22:16:14 -08:00
Luke Arms 1875fe8b40
[Fix] avoid OpenBSD `nvm install` error when /sbin/init doesn't exist
`nvm install` fails with "Binary download failed, trying source" when
- running on Bash;
- errtrace (`set -E`) is enabled;
- an ERR trap uses `exit` to return a non-zero status; and
- /sbin/init doesn't exist.

Resolved by moving `ls -dl /sbin/init` to the following `if` statement.
In this context, returning non-zero isn't an error and the ERR trap
isn't executed.
2021-12-26 15:31:53 +11:00
Luke Arms 81f0f3ec19
[Fix] `set -E`: Add test for `node install` on Bash with an ERR trap and `set -E` 2021-12-27 16:02:25 +11:00
lsfxz fb4538b360
[Fix] add missing `local` (handle nonexisting /sbin/init a bit more cleanly) 2021-11-17 16:59:53 +01:00
Luke LaFountaine d004c6b064
[readme] clarify instructions for running Node on M1 Mac 2021-12-03 16:52:18 -05:00
Bob Bregant II 79ad72d116
[Fix] Update `nvm_extract_tarball` to support OpenBSD
Fixes #2660.
2021-12-19 02:58:18 +00:00
Bob Bregant II ccd442d833
[Refactor] add `nvm_extract_tarball` to consolidate extraction logic 2021-12-19 02:58:18 +00:00
Jordan Harband 9600617c52
v0.39.1 2021-12-17 14:55:52 -08:00
Jordan Harband 5cc74a6736
[Tests] fix failing test 2021-12-17 13:21:29 -08:00
Jordan Harband aa57406ede
[Fix] ensure `unload` removes `nvm_normalize_lts` 2021-12-17 13:55:14 -08:00
Jordan Harband 0f62be6fdd
[Dev Deps] update `markdown-link-check` 2021-12-17 12:37:15 -08:00
Jordan Harband c4c7690dec
[Fix] `ls-remote`/`install`: support `lts/-X` patterns in installs
Fixes #2692
2021-12-16 23:01:05 -08:00
Jordan Harband aed1d732d7
[Fix] `ls-remote`/`install`: properly handle `lts/x` patterns 2021-12-16 22:58:06 -08:00
Jordan Harband 0b4cd8df6c
[Refactor] create `nvm_normalize_lts` helper 2021-12-16 22:55:02 -08:00
Jordan Harband 430860a8be
[Fix] `nvm alias`/`nvm_list_aliases`: support `lts/` aliases
See #2692
2021-12-16 15:54:38 -08:00
Jordan Harband 2459d17741
[Tests] update test mocks 2021-12-16 23:13:15 -08:00
Varun Sharma 6cc90a4b8d
[actions] add step security runner 2021-11-22 07:20:50 -08:00
Jordan Harband 81fc05684d
[Tests] `nvm_get_download_slug`: add unit tests 2021-12-02 23:33:20 -08:00
Ankit Kumar 328dd5004e
[Fix] `nvm_get_download_slug`: better architecture selection for M1 Macs
If the node version is below 16.0.0 then nvm will select x86_64 architecture, else arm64 architecture.
2021-11-21 15:59:39 +05:30
Jérôme Foray 4856407d26
[Fix] `install`: fix method=script install condition
Fixes #2665; see 8937917
2021-11-30 16:07:22 +01:00
Jordan Harband 275001b066
[Tests] fix windows WSL tests 2021-11-25 19:35:39 -08:00
Jordan Harband 89379176ac
[Fix] `install`: properly check for curl/wget 2021-11-25 14:26:35 -08:00
Robert Elliot 30486b9bd9
[readme] Balance the if statement in bash example
Nesting the `elif` at the same level as the `if` and `fi` makes it clear which code applies to which branch (no .nvmrc file / found .nvmrc file).

I wasted a while looking at it trying to work out how it did anything if there was a .nvmrc file, because obviously the `if` didn't match and I couldn't see the `elif` branch.
2021-11-22 14:34:43 +00:00
Ian Grayson e9b26938b9
[readme] Describe another failure case for installing node versions from source on mac arm64 machines.
It seems to be related to https://github.com/nodejs/node/issues/39313 (which describes a similar issue).
2021-11-15 04:23:42 -08:00
Jordan Harband ccd98f7fcb
[Dev Deps] update `doctoc` 2021-11-19 08:59:37 -08:00
Jordan Harband 2f40eeef2e
[shellcheck] apply v0.8.0 updates 2021-11-19 08:53:43 -08:00
Yash Singh f7bed10476
Merge branch 'nvm-sh:master' into master 2021-11-09 11:44:07 -08:00
Nix c9e7bb2da1
[Fix] install script: Add `--no-pager` option to git branch 2021-10-23 22:23:55 +09:00
Yash Singh a680f38f93 Remove extra help 2021-05-11 15:31:53 -07:00
Yash Singh de8ac9cff6 Fix eclint 2021-05-11 15:31:53 -07:00
Yash Singh 33c74fea6e Fix linter 2021-05-11 15:31:53 -07:00
Yash Singh f6bca73860 Fix filename 2021-05-11 15:31:53 -07:00
Yash Singh fb37285d10 Fix unbound variable 2021-05-11 15:31:53 -07:00
Yash Singh c8914252d8 Possibly fix a few tests 2021-05-11 15:31:53 -07:00
Yash Singh e1bbf0b619 Updates 2021-05-11 15:31:53 -07:00
Yash-Singh1 8cd1fd220a Added in comments in .nvmrc and more 2021-05-11 15:31:53 -07:00
Jordan Harband eed0d0e85c
[meta] add project charter and governance 2021-04-26 12:56:08 -07:00
Jordan Harband ad24e96fda
[shellcheck] disable additional `-x` warning from v0.7.2 2021-05-03 14:26:45 -07:00
Jordan Harband b5165ecbe4
[shellcheck] update for new warnings in v0.7.2 2021-05-03 14:19:31 -07:00
Jordan Harband fc87226b23
[readme] move License and Copyright notice sections to the bottom 2021-04-26 11:46:12 -07:00
Jordan Harband f3caa06420
[meta] add OpenJS Foundation copyright notices/links 2021-04-26 11:42:03 -07:00
Jordan Harband 1527ac9d21
[readme] remove redundant "license" section text in favor of LICENSE.md 2021-04-26 11:41:29 -07:00
Jordan Harband bd0ac1e96d
[meta] add `SECURITY.md` 2021-04-22 22:28:41 -07:00
akefirad 117486d4a7
[Fix] `bash_completion`: check if `compinit` is called before calling it
Fixes #2489.
2021-04-16 18:53:35 +02:00
Jordan Harband 07253ecd51
[actions] adjust shellcheck/windows tests to9 have a final "done" job 2021-04-15 22:34:40 -07:00