Commit Graph

2066 Commits

Author SHA1 Message Date
Christopher Dieringer 19222b1835
Merge 8b14f369a1 into 39d9a42c35 2022-02-09 04:36:48 +05:30
Jordan Harband 39d9a42c35
[Fix] `install.sh`: error out if the install instructions are not followed 2022-02-08 10:40:11 -08:00
Kai 2c0c34f10e
[Docs] HTTP => HTTPS 2022-01-16 14:25:11 +01:00
Jordan Harband c2f740ab38
[patch] HTTP -> HTTPS 2022-01-18 12:49:57 -08:00
Jordan Harband 6cfaede5a0
[Fix] `install`: better error message when xcode command line tools are needed
Fixes #2697. Fixes #2663.
2021-11-27 22:16:14 -08:00
Luke Arms 1875fe8b40
[Fix] avoid OpenBSD `nvm install` error when /sbin/init doesn't exist
`nvm install` fails with "Binary download failed, trying source" when
- running on Bash;
- errtrace (`set -E`) is enabled;
- an ERR trap uses `exit` to return a non-zero status; and
- /sbin/init doesn't exist.

Resolved by moving `ls -dl /sbin/init` to the following `if` statement.
In this context, returning non-zero isn't an error and the ERR trap
isn't executed.
2021-12-26 15:31:53 +11:00
Luke Arms 81f0f3ec19
[Fix] `set -E`: Add test for `node install` on Bash with an ERR trap and `set -E` 2021-12-27 16:02:25 +11:00
lsfxz fb4538b360
[Fix] add missing `local` (handle nonexisting /sbin/init a bit more cleanly) 2021-11-17 16:59:53 +01:00
Luke LaFountaine d004c6b064
[readme] clarify instructions for running Node on M1 Mac 2021-12-03 16:52:18 -05:00
Bob Bregant II 79ad72d116
[Fix] Update `nvm_extract_tarball` to support OpenBSD
Fixes #2660.
2021-12-19 02:58:18 +00:00
Bob Bregant II ccd442d833
[Refactor] add `nvm_extract_tarball` to consolidate extraction logic 2021-12-19 02:58:18 +00:00
Jordan Harband 9600617c52
v0.39.1 2021-12-17 14:55:52 -08:00
Jordan Harband 5cc74a6736
[Tests] fix failing test 2021-12-17 13:21:29 -08:00
Jordan Harband aa57406ede
[Fix] ensure `unload` removes `nvm_normalize_lts` 2021-12-17 13:55:14 -08:00
Jordan Harband 0f62be6fdd
[Dev Deps] update `markdown-link-check` 2021-12-17 12:37:15 -08:00
Jordan Harband c4c7690dec
[Fix] `ls-remote`/`install`: support `lts/-X` patterns in installs
Fixes #2692
2021-12-16 23:01:05 -08:00
Jordan Harband aed1d732d7
[Fix] `ls-remote`/`install`: properly handle `lts/x` patterns 2021-12-16 22:58:06 -08:00
Jordan Harband 0b4cd8df6c
[Refactor] create `nvm_normalize_lts` helper 2021-12-16 22:55:02 -08:00
Jordan Harband 430860a8be
[Fix] `nvm alias`/`nvm_list_aliases`: support `lts/` aliases
See #2692
2021-12-16 15:54:38 -08:00
Jordan Harband 2459d17741
[Tests] update test mocks 2021-12-16 23:13:15 -08:00
Varun Sharma 6cc90a4b8d
[actions] add step security runner 2021-11-22 07:20:50 -08:00
Jordan Harband 81fc05684d
[Tests] `nvm_get_download_slug`: add unit tests 2021-12-02 23:33:20 -08:00
Ankit Kumar 328dd5004e
[Fix] `nvm_get_download_slug`: better architecture selection for M1 Macs
If the node version is below 16.0.0 then nvm will select x86_64 architecture, else arm64 architecture.
2021-11-21 15:59:39 +05:30
Jérôme Foray 4856407d26
[Fix] `install`: fix method=script install condition
Fixes #2665; see 8937917
2021-11-30 16:07:22 +01:00
Jordan Harband 275001b066
[Tests] fix windows WSL tests 2021-11-25 19:35:39 -08:00
Jordan Harband 89379176ac
[Fix] `install`: properly check for curl/wget 2021-11-25 14:26:35 -08:00
Robert Elliot 30486b9bd9
[readme] Balance the if statement in bash example
Nesting the `elif` at the same level as the `if` and `fi` makes it clear which code applies to which branch (no .nvmrc file / found .nvmrc file).

I wasted a while looking at it trying to work out how it did anything if there was a .nvmrc file, because obviously the `if` didn't match and I couldn't see the `elif` branch.
2021-11-22 14:34:43 +00:00
Ian Grayson e9b26938b9
[readme] Describe another failure case for installing node versions from source on mac arm64 machines.
It seems to be related to https://github.com/nodejs/node/issues/39313 (which describes a similar issue).
2021-11-15 04:23:42 -08:00
Jordan Harband ccd98f7fcb
[Dev Deps] update `doctoc` 2021-11-19 08:59:37 -08:00
Jordan Harband 2f40eeef2e
[shellcheck] apply v0.8.0 updates 2021-11-19 08:53:43 -08:00
Nix c9e7bb2da1
[Fix] install script: Add `--no-pager` option to git branch 2021-10-23 22:23:55 +09:00
Christopher Dieringer 8b14f369a1
docs: update README.md
Co-authored-by: Jordan Harband <ljharb@gmail.com>
2020-10-11 15:02:03 -07:00
cdaringe 07ed13a7bb
docs: add docker tips 2020-10-11 11:17:13 -07:00
Peter Dave Hello 4436638816
[Tests] Drop deprecated `sudo:` option in TravisCI config
That config was deprecated for a while, reference:
- https://blog.travis-ci.com/2018-10-04-combining-linux-infrastructures
2020-09-21 20:28:09 +08:00
Matthieu Bosquet 344cc32ac3
[readme] bash shell integration: Amended example to call cd when booting a terminal (previously only called on cd).
It means that works with for example VS Code's integrated terminal.
2020-10-05 17:30:03 +01:00
Jordan Harband 7929190e6e
[Docs] improve `nvm --help` output
Fixes #2301
2020-10-02 22:22:12 -07:00
Jordan Harband 8debf39f24
v0.36.0 2020-09-23 16:18:37 -07:00
Jordan Harband c7ca08d575
[Fix] `latest-npm`: ensure npm 7 is not installed on node < 10 2020-09-23 14:50:33 -07:00
Peter Dave Hello 6110d31969
[dockerfile] Add missing apt pacakge `locales`
locale-gen command seems missing since uncertain point for a while:

```
Step 15/33 : RUN locale-gen en_US.UTF-8
 ---> Running in fae073c89c01
 /bin/bash: locale-gen: command not found
 The command '/bin/bash -o pipefail -c locale-gen en_US.UTF-8' returned
 a non-zero code: 127
```

This patch should fix the Docker image build
2020-09-21 18:20:50 +08:00
Peter Dave Hello 68d2f47c0a
[dockerfile] Update ShellCheck download URL in Dockerfile
see koalaman/shellcheck#1871
2020-09-21 09:36:30 +08:00
Jordan Harband 6e0562ac6d
[Tests] pin postcss to v7 2020-09-21 15:40:41 -07:00
Peter Dave Hello 68d331a816
[dockerfile] Remove ShellCheck Segmentation fault workaround
The workaround came from this GitHub issue comment:
https://github.com/koalaman/shellcheck/issues/1053#issuecomment-357816927

Looks like the problem doesn't exist any more:

```
.
.
.
Step 14/33 : RUN shellcheck -V
 ---> Running in 4b7a718c1cbf
ShellCheck - shell script analysis tool
version: 0.7.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
.
.
.
```

The workaround should be removed so that the Dockerfile will be easier
to be understand and read.
2020-09-21 02:47:57 +08:00
Saikat Das 22e07cc0c1
[readme] fix LTS upgrade command
Edited the LTS upgrade scenario command to fix the issue discussed in #2271
2020-08-27 19:27:29 +05:30
Jordan Harband cf92956e5d
[New] add `nvm_find_project_dir` helper 2020-08-23 14:40:42 -07:00
Jordan Harband 1d88ecfce5
[Fix] `nvm_die_on_prefix`: check that the prefix is inside the version dir, not just the nvm dir
- also pass the version dir as the third argument
2020-08-23 22:50:41 -07:00
Jordan Harband 035bf9e28e
[readme] update autocompletion output examples 2020-08-23 23:29:48 -07:00
Michael Potter f7fbad2bd6
[performance] `nvm_auto`: only call `nvm_ls_current` in `use` mode 2020-08-19 11:40:45 -07:00
Steve Lee 19c55b9936
[readme] Mention problem with windows cmd echo 2020-08-11 18:39:32 +01:00
Jordan Harband 9dc6f3e4a5
[Refactor] `nvm run`/`nvm exec`: use `NVM_SILENT` consistently internally 2020-08-13 14:37:41 -07:00
Jordan Harband 1c00753fd9
[New] `nvm deactivate`/`nvm which`: add `--silent` 2020-08-13 13:40:32 -07:00