Commit Graph

927 Commits

Author SHA1 Message Date
Michael Martinez 49a8ec9560 Merge 11507c3f38 into be56ff3b2e 2015-02-07 20:51:05 +00:00
Jordan Harband be56ff3b2e Make sure multiple `nvm run` arguments get passed through to node/iojs properly.
Fixes #641.
2015-02-07 10:09:37 -08:00
Jordan Harband 59e27f8108 Prevent `VERSION=''` output caused by double local declaration.
Fixes #644.
2015-02-03 17:28:40 -08:00
Jordan Harband 0f1f3ed29c v0.23.3 2015-02-02 20:26:00 -08:00
Jordan Harband 2116d2ff91 Filter out the io.js version dir from nvm_ls output.
Fixes #642.
2015-02-02 17:41:04 -08:00
Jordan Harband 0b4c1e14cf Ensure that `nvm run 0.12 --version` errors out sensibly when 0.12 isn't installed. 2015-02-01 13:02:46 -08:00
Jordan Harband e1b7496cf0 Add nvm_is_valid_version 2015-02-01 13:01:40 -08:00
Jordan Harband 8a87133f71 When there's no `nvm run` output, don't echo an empty line. 2015-02-01 12:45:51 -08:00
Jordan Harband 0792945824 Bypass sha1sum/sha1 aliases. Fixes #640. 2015-01-30 23:46:42 -08:00
Jordan Harband a6819b3018 Fix `nvm ls v1.0.3` so that it locates `iojs-v1.0.3`.
Also fix `nvm uninstall v1.0.3` so it won't uninstall it if it's the current version.

node versions will still take priority if there's ever a version overlap.
2015-01-25 12:31:19 -08:00
Jordan Harband 3d3d9d3a8d Merge pull request #633 from gsklee/patch-1
Update README.markdown
2015-01-25 10:13:53 -08:00
G. Kay Lee 3e74bac964 Update README.markdown
Add link to io.js repo as suggested in #618
2015-01-25 15:29:36 +08:00
Jordan Harband 1eaf6b53e4 v0.23.2 2015-01-23 13:53:03 -08:00
Jordan Harband 24c60e4e51 Fix a bug in nvm_remote_version that was breaking `nvm install stable`/`nvm install unstable`.
Fixes #630.
2015-01-23 12:09:13 -08:00
Jordan Harband 8822bd719a v0.23.1 2015-01-23 02:08:36 -08:00
Jordan Harband d90c1eca39 Remove trailing whitespace 2015-01-23 02:08:13 -08:00
Jordan Harband 223f388693 Merge pull request #622 from ohcibi/master
Prefer tee over > to maximize compatibility
2015-01-23 01:52:52 -08:00
Tobias Witt cba5094652
Provide test case for testing the `noclobber` option from zsh
This tests the absence of the bug from #615
2015-01-23 09:29:13 +01:00
Tobias Witt b5d9e547f2
Use `tee` to replace the alias files content instead of `>`
As mentioned in #615 it is possible to configure `>` to not override
existing files by default. `tee` is a standard tool that can be used
shell independent.
2015-01-23 09:29:12 +01:00
Jordan Harband 15598899b6 Merge pull request #628 from imyelo/patch-1
add iojs mirror to README
2015-01-22 20:25:13 -08:00
yelo c8f712a334 add iojs mirror to README 2015-01-23 11:18:51 +08:00
Jordan Harband 2d9494af45 Clarifying install messages, to help with #559 and https://github.com/creationix/nvm/issues/400#issuecomment-71043828 2015-01-22 10:21:04 -08:00
Jordan Harband 2755227d40 Merge pull request #618 from mikeal/patch-1
Adding iojs to README.
2015-01-22 02:27:46 -08:00
Jordan Harband dd146519a2 Improve `nvm use` success output for io.js.
Fixes #623
2015-01-21 22:06:38 -08:00
Jordan Harband 7243bd77d3 Refactor and create `nvm_remote_versions` and `nvm_remote_version`.
Fixes #620 - an oh-my-zsh issue where `nvm install v1` didn't work.
2015-01-21 20:48:25 -08:00
Jordan Harband 7d113a2b2f Inline this use of `nvm_remote_version` 2015-01-21 16:27:20 -08:00
Jordan Harband 17df0b9912 Moving the N/A check earlier in `nvm install` 2015-01-21 16:19:22 -08:00
Jordan Harband 6cac732141 Including this omitted test. 2015-01-20 23:46:29 -08:00
Jordan Harband 9ee864b06f Remove unused variables. 2015-01-20 18:33:51 -08:00
Mikeal Rogers 0471d0ffd6 Adding iojs to README.
Not entirely sure this is the best place for this but it was the best I could find.
2015-01-20 10:21:18 -05:00
Jordan Harband 43a7d78693 v0.23.0 2015-01-19 22:15:06 -08:00
Jordan Harband 879dda6c3d Merge pull request #616 from ljharb/iojs
Add `io.js` support.

This branch adds support for https://github.com/iojs/io.js / https://iojs.org/

The following features should now work:
 - `nvm install iojs` will install the latest `io.js` version. `nvm ls iojs` and `nvm use iojs` will function as you'd expect.
 - `nvm install node` will install the latest stable `node` version. `nvm ls node` and `nvm use node` will function as you'd expect.
 - In general, a specific `io.js` version can be referenced with the "iojs-" prefix. If `node` were to ever release a `v1.0.0`, `v1.0.0` would refer to `node`, and `iojs-v1.0.0` would refer to `io.js`. In the near future, `node-v1.0.0` will also refer to `node` unambiguously. This applies to all `nvm` commands, including working with aliases and `.nvmrc` files.
 - `io.js`, unlike `node`, does not have a SunOS binary. Please open an issue on https://github.com/iojs/io.js if this is actually a problem for anyone, as currently it seems like this won't be for anybody.

**Note**: checksum support upon installation is currently disabled. Relates to https://github.com/iojs/io.js/issues/368.
**Note**: installation of `io.js` directly from source (via the `-s` option) is not yet enabled. This will be added soon.

Relates to https://github.com/iojs/io.js/issues/40 https://github.com/iojs/io.js/issues/420
Fixes #590
2015-01-19 22:14:46 -08:00
Jordan Harband ea12784629 Clean up `nvm ls-remote` behavior when one of node/iojs reports N/A.
This change:
 - removes a superfluous N/A
 - fixes the exit code to return 0 unless no version is found
 - enables `nvm install v1` and similar patterns.
2015-01-19 18:35:05 -08:00
Jordan Harband f1f11e3b7a Ensure `nvm_version node` and `nvm_version node-` report the latest stable node version. 2015-01-19 10:05:36 -08:00
Jordan Harband 247bd310ef Clean up `nvm uninstall node` and `nvm uninstall iojs` behavior. 2015-01-19 10:04:12 -08:00
Jordan Harband dbeeb683da Fix `nvm_strip_path` for >= v0.12.0 node, and all io.js versions. 2015-01-18 23:55:26 -08:00
Jordan Harband 39a75e616d Add support for `nvm use node`, `nvm use iojs`, `nvm ls node`, and `nvm ls iojs`
Also add `nvm_version node` and `nvm_version iojs` support.
2015-01-18 20:45:02 -06:00
Jordan Harband 3cf68dc18d Add `nvm_has_system_iojs` 2015-01-18 20:55:48 -06:00
Jordan Harband 654c37bc29 Make sure to add a test for implicit source installation. 2015-01-18 12:11:21 -06:00
Jordan Harband c6a9f7baae Merge pull request #613 from jsha/https
Move some URLs to HTTPS.
2015-01-18 22:25:12 -08:00
Jacob Hoffman-Andrews bb2564d6db npmjs.org -> npmjs.com 2015-01-18 22:24:22 -08:00
Jacob Hoffman-Andrews 896a7eddd3 Move some URLs to HTTPS. 2015-01-18 12:05:44 -08:00
Jordan Harband 8ae7b33632 Improving failure messages on this test 2015-01-17 11:52:06 -06:00
Jordan Harband eb8c3414dd Move `nvm_get_latest` tests from "installation" to "slow" 2015-01-17 11:52:06 -06:00
Jordan Harband 9615672243 Move node-specific installation tests to their own directory. 2015-01-17 11:52:06 -06:00
Jordan Harband 78c1f2cf9d Split up this `nvm current` and `node 0.6.21-pre` test into separate tests. 2015-01-16 15:36:32 -06:00
Jordan Harband ed22d3de2d Add support for `nvm install node` and `nvm install iojs` 2015-01-16 11:10:37 -06:00
Michael Martinez 11507c3f38 Fixes bug where NVM init script is appended to the wrong startup file
The existence of .bashrc, .bash_profile or .zshrc doesn't prove that the file is the currently utilized startup file or that it is the only file sourced. Because the current code operates under this assumption, the code:

```bash
  export NVM_DIR="/Users/<USERNAME>/.nvm"
  [ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh"  # This loads nvm
```
is getting appended to the wrong profile for zsh users.

1) `[ -d ~/.nvm ] && rm -rfv ~/.nvm `
2) Install Zsh via https://github.com/robbyrussell/oh-my-zsh
3) Run nvm install script with cURL.
4) Run `which nvm`. Observe it's not in `$PATH`
5) Open a new shell session. Observe the issue persists.

To fix this, the code in this PR checks:

- Is `$PROFILE` set? If so, echo it.
- What is the active shell that is executing this script? (the parent shell)
- If the shell is zsh, echo the zshrc file
- If the shell is bash:
	- Is it login or non-login? Echo the neccessary file
	- Is it interactive or non interactive? Echo the neccessary
	  file.

This logic should address the primary bug and also prevent future bugs.

Note: bash by default reads ~/.profile last so it makes sense to write to ~/.bashrc or ~/.bash_profile instead of ~/.profile

See: https://www.gnu.org/software/bash/manual/html_node/Bash-Startup-Files.html

Passed Manual Tests:
  zsh
  bash from within script
  bash as default shell
  bash -l from within zsh
2015-01-15 01:35:36 -08:00
Jordan Harband 448bd38a55 v0.22.2 2015-01-14 15:44:40 -08:00
Jordan Harband 0ad5a450fe Put node versions >= 0.12 in `versions/node` instead of just `versions` 2015-01-14 12:23:06 -08:00