Commit Graph

1911 Commits

Author SHA1 Message Date
Asad Akbar 5c1a817806
Merge 6d9cd2ecdc into 6110d31969 2020-09-22 07:08:48 +05:30
Peter Dave Hello 6110d31969
[dockerfile] Add missing apt pacakge `locales`
locale-gen command seems missing since uncertain point for a while:

```
Step 15/33 : RUN locale-gen en_US.UTF-8
 ---> Running in fae073c89c01
 /bin/bash: locale-gen: command not found
 The command '/bin/bash -o pipefail -c locale-gen en_US.UTF-8' returned
 a non-zero code: 127
```

This patch should fix the Docker image build
2020-09-21 18:20:50 +08:00
Peter Dave Hello 68d2f47c0a
[dockerfile] Update ShellCheck download URL in Dockerfile
see koalaman/shellcheck#1871
2020-09-21 09:36:30 +08:00
Jordan Harband 6e0562ac6d
[Tests] pin postcss to v7 2020-09-21 15:40:41 -07:00
Peter Dave Hello 68d331a816
[dockerfile] Remove ShellCheck Segmentation fault workaround
The workaround came from this GitHub issue comment:
https://github.com/koalaman/shellcheck/issues/1053#issuecomment-357816927

Looks like the problem doesn't exist any more:

```
.
.
.
Step 14/33 : RUN shellcheck -V
 ---> Running in 4b7a718c1cbf
ShellCheck - shell script analysis tool
version: 0.7.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
.
.
.
```

The workaround should be removed so that the Dockerfile will be easier
to be understand and read.
2020-09-21 02:47:57 +08:00
Saikat Das 22e07cc0c1
[readme] fix LTS upgrade command
Edited the LTS upgrade scenario command to fix the issue discussed in #2271
2020-08-27 19:27:29 +05:30
Jordan Harband cf92956e5d
[New] add `nvm_find_project_dir` helper 2020-08-23 14:40:42 -07:00
Jordan Harband 1d88ecfce5
[Fix] `nvm_die_on_prefix`: check that the prefix is inside the version dir, not just the nvm dir
- also pass the version dir as the third argument
2020-08-23 22:50:41 -07:00
Jordan Harband 035bf9e28e
[readme] update autocompletion output examples 2020-08-23 23:29:48 -07:00
Michael Potter f7fbad2bd6
[performance] `nvm_auto`: only call `nvm_ls_current` in `use` mode 2020-08-19 11:40:45 -07:00
Steve Lee 19c55b9936
[readme] Mention problem with windows cmd echo 2020-08-11 18:39:32 +01:00
Jordan Harband 9dc6f3e4a5
[Refactor] `nvm run`/`nvm exec`: use `NVM_SILENT` consistently internally 2020-08-13 14:37:41 -07:00
Jordan Harband 1c00753fd9
[New] `nvm deactivate`/`nvm which`: add `--silent` 2020-08-13 13:40:32 -07:00
Yash-Singh1 b1200c659b
[Fix] `nvm use`: fix `--silent` when version is omitted
Fixed a bug where --silent mode was failing for nvm use I ran a test
 that just ran ```nvm use node --silent``` that I wrote by myself.
 Unfortunately I noticed a bug where it still prints out some messages in
 different cases. This pull request is to fix that bug. * Added in an argument
 called ***quiet***  to the nvm_rc_version() function at *line 339* * Printed
 anything inside the nvm_rc_version() only in the scenario where quiet mode is
 off * Ran the nvm_rc_version() function in quiet mode only if silent mode is
 on in the "use" command of nvm at *line 2990* * Ran *nvm_echo* and *nvm_err*
 inside the "use" command of nvm only in the scenario where silent mode is off
 (There were 4 scenarios where this was forgotten) * Edited the ```nvm
 deactivate``` command to include a silent mode * Changed the help page to
 include the --silent option for ```nvm deactivate``` * Added in aliases for
 the --silent flag in ```nvm deactivate``` and ```nvm use``` * Used silent
 mode inside the ```nvm use``` when running ```nvm deactivate``` inside it and
 silent mode is on A test was attached in the 'test/slow/nvm use' directory.
 It is named *Running "nvm use node --silent" doesn't print anything*. It runs
 ```nvm use node --silent and checks``` and succeeds if the OUTPUT matches the
 EXPECTED_OUTPUT which is *null*  or *''*. When the test was run locally, it
 still ouputed results if someone deleted some contents of the *.nvm/* folder.
 This output was given from the ```nvm deactivate command```. This was the
 reason that the ```nvm deactivate``` was edited to include silent mode.
2020-08-08 17:27:46 -07:00
Jordan Harband 16b75b7333
[Robustness] add `command` to `xargs`/`rm` in `nvm_get_default_packages`
Fixes #2281.
2020-08-11 10:16:42 -07:00
Naomi Quinones 1bf567bd0b
[Fix] ensure `--help` is intercepted on any command
Co-authored-by: Naomi Quinones <52065567+naomiquinones@users.noreply.github.com>
Co-authored-by: Dena Burd <me@Denas-MacBook-Air.local>
2020-08-04 16:32:19 -07:00
Dimitris Karagiannis a01deb11dc
[patch] Update docs and add warning for 'nvm is not compatible with the npm config "prefix" option' edgecase error on Mac OS 2020-08-03 10:04:20 -07:00
Asad Akbar 6d9cd2ecdc [Docs] Update README for install notes
* Changes the suggested shell when running the install script to $SHELL
  which will return the default shell.
* Adds a note for how to fix the issue when the install script is not
  updating the correct profile file.
2020-06-25 14:07:28 -07:00
Connor Leech 7b3af45cf7
[readme] Update install instructions troubleshooting
This is in response to a popular stack overflow answer that has helped people resolve the "command not found" hiccup: https://stackoverflow.com/a/17707224/2031033

Also mentioned here: https://github.com/nvm-sh/nvm/issues/748
2020-05-25 07:36:40 -07:00
Peter Dave Hello bac5393e12
[Docs] Syntax highlight for Ansible task example in README.md 2020-05-29 21:01:47 +08:00
Szymon Dzialowski 2d4e877b61
[readme] Stop removing spaces from nvm_path
It breaks switching version of node through nvm in directories with space somewhere in it's path.
2020-06-10 18:28:14 +01:00
Jordan Harband 6575b6b052
[Fix] `install`: improved arg parsing around `--reinstall-packages-from`
Fixes #1762
2020-06-04 16:15:39 -07:00
Bruce A. MacNaughton 33fa27dabe
[Docs] Update README for environment variables 2020-02-07 12:01:57 -08:00
Sehrope Sarkuni 91a55dd91a
[Refactor] Rename solaris and iojs helper functions to be nvm_ prefixed
Renames node_version_has_solaris_binary and nvm_iojs_version_has_solaris_binary
to be prefixed with nvm_ so they do not show up in tab completion following the
word "node".
2020-05-08 16:08:27 -04:00
Jordan Harband 7aba64a2d5
[meta] further TOC action tweaks 2020-04-29 20:18:40 -07:00
Jared Ramirez dcc8059ef8
[readme] include deeper integration instructions for fish 2020-04-29 15:25:23 -07:00
Jordan Harband 8e1e5df059
[meta] fix TOC action 2020-04-29 15:13:30 -07:00
Jordan Harband e0ed1eacfd
[meta] add actions: Automatic Rebase for PRs, auto-update-TOC for push 2020-04-29 12:06:01 -07:00
Peter Dave Hello 73438e339e
Update Dockerfile base image to Ubuntu 16.04, cc #2008 2020-03-30 02:17:28 +08:00
Magnus Markling b02617028f
[Tests] Source nvm.sh before defining FILE 2020-03-19 12:13:29 +01:00
Jordan Harband f607f2f783
[Fix] `reinstall-packages`: do not include unmet peer deps
Closes #1948.
2020-03-10 23:51:17 -07:00
Jordan Harband 258938ef66
v0.35.3 2020-03-05 23:13:56 -08:00
Jordan Harband 096ba0d8c3
`uninstall`: add `NVM_DEBUG` to print out a filename as its permissions are checked 2020-03-05 17:40:17 -08:00
Jordan Harband 4626d1aae6
[New] add `lts/-1` etc, to point to an LTS line relative to "latest" 2020-03-04 01:03:36 -08:00
Jordan Harband c372ff03e0
[Tests] update mocks 2020-03-04 00:44:35 -08:00
Jordan Harband 30cd9c5dc8
[Tests] fix update mocks script 2020-03-04 00:57:58 -08:00
Jordan Harband b9536327ae
[Fix] `nvm ls-remote`: properly label latest LTS versions instead of just the latest one in the filter
Fixes #2166
2020-02-21 21:27:13 -08:00
Jordan Harband e609091a55
[Tests] update test mocks 2020-02-22 09:06:59 -08:00
flip111 8093dbeacd
[readme] add nvm intro
Closes #2149.
2020-01-23 20:32:07 +01:00
Jordan Harband 4cd6b4822c
[Tests] try to make `nvm unload` test more robust 2020-02-09 06:41:52 -10:00
Bruce A. MacNaughton 6c560b12b6
[New] `use`: set `NVM_INC` to expose the node include path 2020-02-07 06:23:35 -08:00
Jordan Harband f4eddb2c9c
[Tests] ensure `nvm unload` unsets env vars too 2020-02-07 09:16:55 -10:00
Jordan Harband a1ad32e9cb
[readme] restore broken anchor 2020-01-11 18:15:20 -08:00
nebbles d8785da988
[Docs] Improve readme clarity and troubleshooting
Clean up readme structure a bit to help with readability. fix
instructions which could lead to a sourcing loop if misinterpreted.
guidance should direct macos users to simply copy the source snippet
manually into their desired profile file.

Resolve #2123
2019-11-17 14:52:52 +00:00
Lucian Buzzo 4ff9084e99
[Docs] Fix small typo in README 2019-12-05 10:07:38 +00:00
Jordan Harband f355b327d6
v0.35.2 2019-12-17 22:40:20 -08:00
Jordan Harband 6fa92c82ca
[Fix] if a prefix env var is set (as in npm run), but is correct, do not fail
Fixes #2106.
2019-12-15 23:39:32 -08:00
Jordan Harband 0899839b95
[Tests] pin `david` to v11
v11.1.0 and v12 no longer work on node 0.10; v11.1.1 should.

See https://github.com/alanshaw/david/issues/159
2019-12-09 08:51:46 -08:00
Jordan Harband 73a513c389
[Fix] allow `nvm unalias x` when `x` is a default alias, but shadowed
Fixes #2122.
2019-11-12 11:16:08 -08:00
awthwathje 04ad1b528c
[readme] Fix a typo 2019-11-08 10:24:16 +01:00