Commit Graph

2065 Commits

Author SHA1 Message Date
Jordan Harband 984747ea06
Merge c8d70e07b7 into 39d9a42c35 2022-02-09 04:36:34 +05:30
Jordan Harband 39d9a42c35
[Fix] `install.sh`: error out if the install instructions are not followed 2022-02-08 10:40:11 -08:00
Kai 2c0c34f10e
[Docs] HTTP => HTTPS 2022-01-16 14:25:11 +01:00
Jordan Harband c2f740ab38
[patch] HTTP -> HTTPS 2022-01-18 12:49:57 -08:00
Jordan Harband 6cfaede5a0
[Fix] `install`: better error message when xcode command line tools are needed
Fixes #2697. Fixes #2663.
2021-11-27 22:16:14 -08:00
Luke Arms 1875fe8b40
[Fix] avoid OpenBSD `nvm install` error when /sbin/init doesn't exist
`nvm install` fails with "Binary download failed, trying source" when
- running on Bash;
- errtrace (`set -E`) is enabled;
- an ERR trap uses `exit` to return a non-zero status; and
- /sbin/init doesn't exist.

Resolved by moving `ls -dl /sbin/init` to the following `if` statement.
In this context, returning non-zero isn't an error and the ERR trap
isn't executed.
2021-12-26 15:31:53 +11:00
Luke Arms 81f0f3ec19
[Fix] `set -E`: Add test for `node install` on Bash with an ERR trap and `set -E` 2021-12-27 16:02:25 +11:00
lsfxz fb4538b360
[Fix] add missing `local` (handle nonexisting /sbin/init a bit more cleanly) 2021-11-17 16:59:53 +01:00
Luke LaFountaine d004c6b064
[readme] clarify instructions for running Node on M1 Mac 2021-12-03 16:52:18 -05:00
Bob Bregant II 79ad72d116
[Fix] Update `nvm_extract_tarball` to support OpenBSD
Fixes #2660.
2021-12-19 02:58:18 +00:00
Bob Bregant II ccd442d833
[Refactor] add `nvm_extract_tarball` to consolidate extraction logic 2021-12-19 02:58:18 +00:00
Jordan Harband 9600617c52
v0.39.1 2021-12-17 14:55:52 -08:00
Jordan Harband 5cc74a6736
[Tests] fix failing test 2021-12-17 13:21:29 -08:00
Jordan Harband aa57406ede
[Fix] ensure `unload` removes `nvm_normalize_lts` 2021-12-17 13:55:14 -08:00
Jordan Harband 0f62be6fdd
[Dev Deps] update `markdown-link-check` 2021-12-17 12:37:15 -08:00
Jordan Harband c4c7690dec
[Fix] `ls-remote`/`install`: support `lts/-X` patterns in installs
Fixes #2692
2021-12-16 23:01:05 -08:00
Jordan Harband aed1d732d7
[Fix] `ls-remote`/`install`: properly handle `lts/x` patterns 2021-12-16 22:58:06 -08:00
Jordan Harband 0b4cd8df6c
[Refactor] create `nvm_normalize_lts` helper 2021-12-16 22:55:02 -08:00
Jordan Harband 430860a8be
[Fix] `nvm alias`/`nvm_list_aliases`: support `lts/` aliases
See #2692
2021-12-16 15:54:38 -08:00
Jordan Harband 2459d17741
[Tests] update test mocks 2021-12-16 23:13:15 -08:00
Varun Sharma 6cc90a4b8d
[actions] add step security runner 2021-11-22 07:20:50 -08:00
Jordan Harband 81fc05684d
[Tests] `nvm_get_download_slug`: add unit tests 2021-12-02 23:33:20 -08:00
Ankit Kumar 328dd5004e
[Fix] `nvm_get_download_slug`: better architecture selection for M1 Macs
If the node version is below 16.0.0 then nvm will select x86_64 architecture, else arm64 architecture.
2021-11-21 15:59:39 +05:30
Jérôme Foray 4856407d26
[Fix] `install`: fix method=script install condition
Fixes #2665; see 8937917
2021-11-30 16:07:22 +01:00
Jordan Harband 275001b066
[Tests] fix windows WSL tests 2021-11-25 19:35:39 -08:00
Jordan Harband 89379176ac
[Fix] `install`: properly check for curl/wget 2021-11-25 14:26:35 -08:00
Robert Elliot 30486b9bd9
[readme] Balance the if statement in bash example
Nesting the `elif` at the same level as the `if` and `fi` makes it clear which code applies to which branch (no .nvmrc file / found .nvmrc file).

I wasted a while looking at it trying to work out how it did anything if there was a .nvmrc file, because obviously the `if` didn't match and I couldn't see the `elif` branch.
2021-11-22 14:34:43 +00:00
Ian Grayson e9b26938b9
[readme] Describe another failure case for installing node versions from source on mac arm64 machines.
It seems to be related to https://github.com/nodejs/node/issues/39313 (which describes a similar issue).
2021-11-15 04:23:42 -08:00
Jordan Harband ccd98f7fcb
[Dev Deps] update `doctoc` 2021-11-19 08:59:37 -08:00
Jordan Harband 2f40eeef2e
[shellcheck] apply v0.8.0 updates 2021-11-19 08:53:43 -08:00
Nix c9e7bb2da1
[Fix] install script: Add `--no-pager` option to git branch 2021-10-23 22:23:55 +09:00
Jordan Harband c8d70e07b7
[Robustness] handle an overridden `type`
Fixes #2352
2020-11-21 13:33:12 -08:00
Andrew Shield b19d8dbbba
[readme] Update source command to include s in zsh 2021-03-18 16:07:24 +13:00
Jordan Harband 0579718308
[Fix] install script: define `nvm_echo`
- refactor `echo` to use `nvm_echo`

Per 589c2377fb (r48360520)
2021-03-17 09:07:15 -07:00
Marcin Kłopotek 8884fd32f6
[readme] Add `nvs` as one of the Windows alternatives
Co-authored-by: Jordan Harband <ljharb@gmail.com>
2021-03-01 13:28:09 +01:00
Sladyn Nunes 25d2ebf2f8
[readme] add headings to certain sections
Fixes #2413.
2021-03-03 20:47:44 +05:30
Jordan Harband 9cb6a2b614
[Tests] ensure `doctoc` action fails when it should 2021-03-17 08:11:37 -07:00
artforlife 216ccd62f7
[readme] add commands to help troubleshoot without closing the current shell
Co-authored-by: artforlife <artforlife@users.noreply.github.com>
Co-authored-by: Sladyn Nunes <sladynnunes98@gmail.com>
2020-04-26 12:57:50 -05:00
Rodrigo Espinosa de los Monteros 4da7f101a2
[Fix] `nvm_alias`: ensure `lts/-1` returns the one before `lts/*`
Fixes #2461
2021-03-11 16:22:31 -05:00
Jordan Harband 641f86879f
[Tests] update mocks
- make call count test depend on mocks
2021-03-11 13:06:41 -08:00
Lukman 1081ed161b
[New] `install`: add parallel build support for openbsd
Co-authored-by: Lukman <lukmaan.me@gmail.com>
Co-authored-by: Sladyn Nunes <sladynnunes98@gmail.com>
2020-12-26 22:23:35 +05:30
Vesa Vilhonen 52f67b3677
[Fix] `exec`: `--` should stop argument parsing
Co-authored-by: Vesa Vilhonen <vesa@vilhonen.com>
Co-authored-by: Sladyn Nunes <sladynnunes98@gmail.com>
2020-11-20 13:06:28 +02:00
Sladyn Nunes 4fdef427e4
[New] `install`: add `-b` flag to skip building from source
Fixes #2114.
2021-02-16 19:34:23 +05:30
farmer d9b11ba208
[readme] update `cdnvm` implementation 2021-02-19 21:12:03 +08:00
Jordan Harband 87f37909f2
[meta] add CODE_OF_CONDUCT.md 2021-02-15 14:33:44 -08:00
nmarghetti 7f6c0c053a
[Refactor] add `nvm_install_binary_extract` 2021-01-02 00:03:24 +01:00
nmarghetti d396181ffb
[Refactor] add `nvm_get_artifact_compression` 2021-01-02 00:03:24 +01:00
shiyutim a5742d4e9e
[readme] add install error tips 2021-01-07 10:51:33 +08:00
David Zulaica d5c1441a83 [readme] Update M1 macOS troubleshooting instructions 2021-02-13 03:41:41 -08:00
Arshath 0fad5ec575
[readme] quote asterisk in shell command on `--latest-npm` example 2021-02-05 19:45:26 +05:30