Commit Graph

2065 Commits

Author SHA1 Message Date
Wes Todd f60c344527
Merge 752ed000e5 into 39d9a42c35 2022-02-09 04:36:48 +05:30
Jordan Harband 39d9a42c35
[Fix] `install.sh`: error out if the install instructions are not followed 2022-02-08 10:40:11 -08:00
Kai 2c0c34f10e
[Docs] HTTP => HTTPS 2022-01-16 14:25:11 +01:00
Jordan Harband c2f740ab38
[patch] HTTP -> HTTPS 2022-01-18 12:49:57 -08:00
Jordan Harband 6cfaede5a0
[Fix] `install`: better error message when xcode command line tools are needed
Fixes #2697. Fixes #2663.
2021-11-27 22:16:14 -08:00
Luke Arms 1875fe8b40
[Fix] avoid OpenBSD `nvm install` error when /sbin/init doesn't exist
`nvm install` fails with "Binary download failed, trying source" when
- running on Bash;
- errtrace (`set -E`) is enabled;
- an ERR trap uses `exit` to return a non-zero status; and
- /sbin/init doesn't exist.

Resolved by moving `ls -dl /sbin/init` to the following `if` statement.
In this context, returning non-zero isn't an error and the ERR trap
isn't executed.
2021-12-26 15:31:53 +11:00
Luke Arms 81f0f3ec19
[Fix] `set -E`: Add test for `node install` on Bash with an ERR trap and `set -E` 2021-12-27 16:02:25 +11:00
lsfxz fb4538b360
[Fix] add missing `local` (handle nonexisting /sbin/init a bit more cleanly) 2021-11-17 16:59:53 +01:00
Luke LaFountaine d004c6b064
[readme] clarify instructions for running Node on M1 Mac 2021-12-03 16:52:18 -05:00
Bob Bregant II 79ad72d116
[Fix] Update `nvm_extract_tarball` to support OpenBSD
Fixes #2660.
2021-12-19 02:58:18 +00:00
Bob Bregant II ccd442d833
[Refactor] add `nvm_extract_tarball` to consolidate extraction logic 2021-12-19 02:58:18 +00:00
Jordan Harband 9600617c52
v0.39.1 2021-12-17 14:55:52 -08:00
Jordan Harband 5cc74a6736
[Tests] fix failing test 2021-12-17 13:21:29 -08:00
Jordan Harband aa57406ede
[Fix] ensure `unload` removes `nvm_normalize_lts` 2021-12-17 13:55:14 -08:00
Jordan Harband 0f62be6fdd
[Dev Deps] update `markdown-link-check` 2021-12-17 12:37:15 -08:00
Jordan Harband c4c7690dec
[Fix] `ls-remote`/`install`: support `lts/-X` patterns in installs
Fixes #2692
2021-12-16 23:01:05 -08:00
Jordan Harband aed1d732d7
[Fix] `ls-remote`/`install`: properly handle `lts/x` patterns 2021-12-16 22:58:06 -08:00
Jordan Harband 0b4cd8df6c
[Refactor] create `nvm_normalize_lts` helper 2021-12-16 22:55:02 -08:00
Jordan Harband 430860a8be
[Fix] `nvm alias`/`nvm_list_aliases`: support `lts/` aliases
See #2692
2021-12-16 15:54:38 -08:00
Jordan Harband 2459d17741
[Tests] update test mocks 2021-12-16 23:13:15 -08:00
Varun Sharma 6cc90a4b8d
[actions] add step security runner 2021-11-22 07:20:50 -08:00
Jordan Harband 81fc05684d
[Tests] `nvm_get_download_slug`: add unit tests 2021-12-02 23:33:20 -08:00
Ankit Kumar 328dd5004e
[Fix] `nvm_get_download_slug`: better architecture selection for M1 Macs
If the node version is below 16.0.0 then nvm will select x86_64 architecture, else arm64 architecture.
2021-11-21 15:59:39 +05:30
Jérôme Foray 4856407d26
[Fix] `install`: fix method=script install condition
Fixes #2665; see 8937917
2021-11-30 16:07:22 +01:00
Jordan Harband 275001b066
[Tests] fix windows WSL tests 2021-11-25 19:35:39 -08:00
Jordan Harband 89379176ac
[Fix] `install`: properly check for curl/wget 2021-11-25 14:26:35 -08:00
Robert Elliot 30486b9bd9
[readme] Balance the if statement in bash example
Nesting the `elif` at the same level as the `if` and `fi` makes it clear which code applies to which branch (no .nvmrc file / found .nvmrc file).

I wasted a while looking at it trying to work out how it did anything if there was a .nvmrc file, because obviously the `if` didn't match and I couldn't see the `elif` branch.
2021-11-22 14:34:43 +00:00
Ian Grayson e9b26938b9
[readme] Describe another failure case for installing node versions from source on mac arm64 machines.
It seems to be related to https://github.com/nodejs/node/issues/39313 (which describes a similar issue).
2021-11-15 04:23:42 -08:00
Jordan Harband ccd98f7fcb
[Dev Deps] update `doctoc` 2021-11-19 08:59:37 -08:00
Jordan Harband 2f40eeef2e
[shellcheck] apply v0.8.0 updates 2021-11-19 08:53:43 -08:00
Nix c9e7bb2da1
[Fix] install script: Add `--no-pager` option to git branch 2021-10-23 22:23:55 +09:00
Wes Todd 752ed000e5 fix: do not log when user has requested no profile modifications 2019-12-05 19:30:26 -08:00
Jordan Harband 73a513c389
[Fix] allow `nvm unalias x` when `x` is a default alias, but shadowed
Fixes #2122.
2019-11-12 11:16:08 -08:00
awthwathje 04ad1b528c
[readme] Fix a typo 2019-11-08 10:24:16 +01:00
Jordan Harband 1c8e59130f [meta] create FUNDING.yml 2019-11-05 12:05:09 -08:00
Jordan Harband 28bc2fd991
v0.35.1 2019-11-03 10:03:31 -08:00
Jordan Harband 100861d529
[Fix] `install-latest-npm`: `npm` `v6.10` breaks on `node` `v6.0`, `v6.1`, and `v9.0`-`v9.2` 2019-11-02 20:53:18 -07:00
Marit Iren 1eca354233
[Docs] Add description if instructions don't work; make install instructions more readable 2019-10-20 17:08:29 +02:00
Guido Bouman 0a4e6f2b70
[meta] Update ISSUE_TEMPLATE.md
Remove the need to indent terminal output by using headings instead of a list.
Simplify formulation of steps
2019-10-08 15:27:53 +02:00
Jordan Harband 94a72ae217
[Fix] `nvm use`: improve help output with bare `nvm use` and no `.nvmrc`
Closes #1914.
2019-10-08 14:40:17 -07:00
Jordan Harband 011810e721
v0.35.0 2019-10-02 00:05:28 -04:00
Darío Hereñú d48abff659
[Docs] clean up formatting in readme 2019-05-03 19:44:21 -03:00
Darío Hereñú 82037b41b1
[Docs] clean up a bit 2017-10-06 01:54:07 -03:00
Roman Isko 7b0a46eafb
[docker] add libssl-dev to Docker image 2018-06-18 10:33:12 +03:00
Roman Isko dcbecbf2c7
[shellcheck] install shellcheck v0.6.0 in Dockerfile 2018-06-14 10:45:01 +03:00
metasean 970cadf258
[Docs] Add `--latest-npm` info to Migrating global packages section
Adds the following information to the "Migrating global packages while installing" section:
- notification that the npm package is explicitly not updated when using the --reinstall-packages-from flag
- information about the --latest-npm flag
- recovery instructions if a user has already updated node with an incompatible npm version
2018-12-30 18:24:29 -07:00
Will Papper 3cc9525dce
[Docs] [Fix] Set $NVM_DIR to ".nvm" instead of "nvm"
- Operating system and version: Mac OS X Mojave

- What happened? $NVM_DIR was set to nvm

- What did you expect to happen? $NVM_DIR should be set to .nvm
I added the following line from the README to my .zshrc:
```
export NVM_DIR="${XDG_CONFIG_HOME/:-$HOME/.}nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" # This loads nvm
```

I couldn't figure out why nvm wasn't loading, until I realized that
`echo NVM_DIR="${XDG_CONFIG_HOME/:-$HOME/.}nvm"` outputs `NVM_DIR=nvm`.

Changing the line to `export NVM_DIR="${XDG_CONFIG_HOME/:-$HOME/}.nvm"` fixed the problem. This outputs `NVM_DIR=.nvm` as expected. I tested this and the same behavior holds true in Bash as well.
2019-04-24 00:03:01 -07:00
Greg Smith 6537c91eb5
Fix bash auto-use nvm command
It was trying to read ./.nvmrc if you cd'ed into a subdirectory of the directory that has .nvmrc, which would give print `-bash: ./.nvmrc: No such file or directory` to stderr and potentially not doing the `nvm install`.
2019-08-09 14:38:37 -06:00
Jordan Harband 07b20d5008
[meta] add copyright line to license file 2019-07-17 10:48:23 -07:00
Sehrope Sarkuni 0b5bb5ccd8
[Fix] `set -u`: Add default empty value for `$NVM_NO_ALIAS`
Adds a default value for NVM_NO_ALIAS so that nvm ls does not error out when run
in a bash nounset/-u (no unset vars) environment.
2019-05-14 08:31:24 -04:00